Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update var.tar.gz creation #167

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Update var.tar.gz creation #167

merged 1 commit into from
Sep 20, 2023

Conversation

vladbogo
Copy link
Collaborator

@vladbogo vladbogo commented Sep 4, 2023 •
edited
Loading

  • Only save *.err files
  • Set MTR --max-save-datadir=10

@vladbogo vladbogo requested a review from grooverdan September 4, 2023 16:33
grooverdan
grooverdan requested changes Sep 4, 2023
View reviewed changes
Copy link
Member

@grooverdan grooverdan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed. *.err files are already there.

var.tar.gz containing datadir is useful.

Take --max-save-datadir=10 as a separate change. Ensure other test runs include the same too (maybe it should be the default in the server).

common_factories.py Show resolved Hide resolved
utils.py Outdated Show resolved Hide resolved
@montywi
Copy link

montywi commented Sep 5, 2023 via email

@vladbogo
Copy link
Collaborator Author

vladbogo commented Sep 5, 2023

How about .err.warnings? Are those files needed?

@grooverdan
Copy link
Member

How about .err.warnings? Are those files needed?

Only files over size 200 bytes contain anything interesting. The ~100 byte files just contain a header.

The regexes in mariadb-test-run.pl that generate these '.warning' files seem rather unmaintained with last update ~5 years ago. I'm going towards the side no-one looks. Most from a sampling I looked at seemed to be InnoDB errors and replication errors generated in the normal execution of exception functionality test (error handling).

So lets remove the core.tar.gz handling and then looks right too me.

@vladbogo
Update var.tar.gz creation
5eaf080 
* Only save *.err files
* Set MTR --max-save-datadir=10
@vladbogo
Copy link
Collaborator Author

vladbogo commented Sep 6, 2023

@grooverdan I update to change all occurrences of max-save-datadir and removed the core file handling

@vladbogo vladbogo requested a review from grooverdan September 6, 2023 13:11
@grooverdan
Copy link
Member

grooverdan commented Sep 8, 2023 •
edited
Loading

Edit - was the second failure so maybe that's why it wasn't saved.

Never mind:
From https://ci.mariadb.org/38053/logs/amd64-ubuntu-2004-debug/ in the var file,

./mysql-test/var/22/log/mysql_client_test.out.log was useful

Was an intentional change - 081c0f10894771c00659b63c042502ecfc4fe938

e.g.: https://jira.mariadb.org/browse/MDEV-15096 - saving mysql-test/var/1/log/mysql_client_test.out.log would be good.

maybe fix the MTR to include it, but for now an explicit glob for this file.

@vladbogo
Copy link
Collaborator Author

@grooverdan so then all mysql-test/var/*/log/*.log are needed?

@grooverdan
Copy link
Member

@grooverdan so then all mysql-test/var/*/log/*.log are needed?

Nope, increasing max-save-datadir resolves this.

@grooverdan grooverdan merged commit 6a23601 into MariaDB:main Sep 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grooverdan grooverdan grooverdan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladbogo @montywi @grooverdan